robuster logger for files

1 files changed, 9 insertions, 5 deletions

diff --git a/src/log.c b/src/log.c
index ad6080f..a004e79 100644
--- a/src/log.c
+++ b/src/log.c
@@ -1,9 +1,10 @@
 #include "log.h"
 
 #include "port/stdio.h"			/* for vsnprintf */
-#include "port/string.h"		/* for strcmp */
+#include "port/string.h"		/* for strcmp, strerror_r */
 
 #include <stdarg.h>			/* for variable arguments */
+#include <errno.h>			/* for errno */
 
 const char *log_syslog_facility_to_str( int facility ) {
 	switch( facility ) {
@@ -94,12 +95,9 @@ static int syslog_facility;
 static int syslog_level;
 
 void openlogtofile( const char *filename, int level ) {
-	if( log_file != NULL ) {
-		fclose( log_file );
-	}
-	log_file = fopen( filename, "a" );
 	log_logfile_filename = filename;
 	log_logfile_level = level;
+	reopenlogtofile( );
 }
 
 void openlogtosyslog( const char *ident, int facility, int level ) {
@@ -134,6 +132,12 @@ void reopenlogtofile( void ) {
 		fclose( log_file );
 	}
 	log_file = fopen( log_logfile_filename, "a" );
+	if( log_file == NULL ) {
+		char errmsg[255];
+		strerror_r( errno, errmsg, 255 );
+		fprintf( stderr, "ERR: Unable to logfile '%s': %s\n",
+			log_logfile_filename, errmsg );
+	}
 }
 
 void reopenlogtosyslog( void ) {